Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20277#discussion_r162748352
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java 
---
    @@ -55,164 +43,82 @@ public void close() {
         if (childColumns != null) {
           for (int i = 0; i < childColumns.length; i++) {
             childColumns[i].close();
    +        childColumns[i] = null;
    --- End diff --
    
    Is it OK not to call `close()` while `ColumnVector.close()` is provided?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to