Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r163115184
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -46,6 +46,19 @@ class JoinOptimizationSuite extends PlanTest {
val testRelation = LocalRelation('a.int, 'b.int, 'c.int)
val testRelation1 = LocalRelation('d.int)
+ def testExtractInnerJoins
+ (plan: LogicalPlan, expected: Option[(Seq[(LogicalPlan, InnerLike)],
Seq[Expression])]) {
+ ExtractFiltersAndInnerJoins.unapply(plan) match {
+ case Some((input, conditions)) =>
+ expected.map { case (expectedPlans, expectedConditions) =>
+ assert(expectedPlans.toSet === input.toSet)
--- End diff --
Won't this ignore the plans sequence?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
