Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20355#discussion_r163137474
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
 ---
    @@ -172,6 +172,14 @@ class TextSuite extends QueryTest with 
SharedSQLContext {
         }
       }
     
    +  test("SPARK-23148: test for spaces in file names") {
    --- End diff --
    
    Shall we remove this test case and only leave test CSV / JSON with 
`multiLine` enabled? I think other tests are basically duplicates of 
https://github.com/apache/spark/blob/a0aedb0ded4183cc33b27e369df1cbf862779e26/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala#L71.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to