Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20366#discussion_r163353845
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -113,7 +132,7 @@ private[feature] trait CountVectorizerParams extends
Params with HasInputCol wit
/** @group getParam */
def getBinary: Boolean = $(binary)
- setDefault(vocabSize -> (1 << 18), minDF -> 1.0, minTF -> 1.0, binary ->
false)
+ setDefault(vocabSize -> (1 << 18), minDF -> 1.0, minTF -> 1.0, binary ->
false, maxDF -> Long.MaxValue)
--- End diff --
what about avoiding to set a default value and apply the filter only if it
was set?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
