Github user ymazari commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r163359719
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -113,7 +132,11 @@ private[feature] trait CountVectorizerParams extends
Params with HasInputCol wit
/** @group getParam */
def getBinary: Boolean = $(binary)
- setDefault(vocabSize -> (1 << 18), minDF -> 1.0, minTF -> 1.0, binary ->
false)
+ setDefault(vocabSize -> (1 << 18),
+ minDF -> 1.0,
+ maxDF -> Long.MaxValue,
--- End diff --
> by @mgaido91: what about avoiding to set a default value and apply the
filter only if it was set?
That'd be easy to do, but would make the code a couple lines longer.
I will do it if you think it's really better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
