Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163631446
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
if (ret != null) {
// hive.metastore.warehouse.dir is determined in SharedState after
the CliSessionState
// instance constructed, we need to follow that change here.
- warehouseDir.foreach { dir =>
+ val conf = hadoopConf.asInstanceOf[Configuration]
--- End diff --
Actually I'm not sure just what I suggested will work. You need to
reproduce the condition to trigger the `if` above:
```
val ret = SessionState.get
if (ret != null) { if (ret != null) {
```
And I'm not sure how to do that. I'm just sure that if you do, your code
will not work.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
