Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20224#discussion_r163747941
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -629,6 +629,13 @@ object SQLConf {
         .booleanConf
         .createWithDefault(true)
     
    +  val WHOLESTAGE_CODEGEN_USE_ID_IN_CLASS_NAME =
    +    buildConf("spark.sql.codegen.wholeStage.useIdInClassName")
    --- End diff --
    
    nit: It seems other whole stage codegen configs don't have the `wholeStage` 
prefix, shall we remove it to make them consistent?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to