Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19285#discussion_r163807859
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -702,6 +634,93 @@ private[spark] class MemoryStore(
       }
     }
     
    +private trait ValuesBuilder[T] {
    +  def preciseSize: Long
    --- End diff --
    
    Hey guys, why not name the trait as `MemoryEntryBuilder`?  As I see from 
the code, it is used to build the `MemoryEntry`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to