Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20369#discussion_r164011714
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/sources/StreamingDataSourceV2Suite.scala
 ---
    @@ -184,6 +184,24 @@ class StreamingDataSourceV2Suite extends StreamTest {
         }
       }
     
    +  test("disabled v2 write") {
    +    // Ensure the V2 path works normally and generates a V2 sink..
    +    val v2Query = testPositiveCase(
    +      "fake-read-microbatch-continuous", "fake-write-v1-fallback", 
Trigger.Once())
    +    assert(v2Query.asInstanceOf[StreamingQueryWrapper].streamingQuery.sink
    +      .isInstanceOf[FakeWriteV1Fallback])
    +
    +    // Ensure we create a V1 sink with the config. Note the config is a 
comma separated
    +    // list, including other fake entries.
    +    val fullSinkName = 
"org.apache.spark.sql.streaming.sources.FakeWriteV1Fallback"
    +    withSQLConf("spark.sql.streaming.disabledV2Writers" -> 
s"a,b,c,test,$fullSinkName,d,e") {
    --- End diff --
    
    "spark.sql.streaming.disabledV2Writers" -> 
SQLConf.DISABLED_V2_STREAMING_WRITERS.key



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to