Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13599#discussion_r164032982
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -98,7 +98,7 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
       private val reviveThread =
         
ThreadUtils.newDaemonSingleThreadScheduledExecutor("driver-revive-thread")
     
    -  class DriverEndpoint(override val rpcEnv: RpcEnv, sparkProperties: 
Seq[(String, String)])
    +  class DriverEndpoint(override val rpcEnv: RpcEnv)
    --- End diff --
    
    My question here is why is this change needed? Changing the scheduler 
backend is weird for this change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to