Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20367#discussion_r164273743
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -155,24 +182,47 @@ class CountVectorizer @Since("1.5.0")
(@Since("1.5.0") override val uid: String)
transformSchema(dataset.schema, logging = true)
val vocSize = $(vocabSize)
val input =
dataset.select($(inputCol)).rdd.map(_.getAs[Seq[String]](0))
+ val filteringRequired = isSet(minDF) || isSet(maxDF)
--- End diff --
yes, this is the right condition to choose whether to `filter` or not, but
the right one to choose whether to do the count or not is the one you just
stated
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
