Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2840#discussion_r19167889
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
---
@@ -66,7 +66,15 @@ private[spark] object CoarseGrainedClusterMessages {
case class RemoveExecutor(executorId: String, reason: String) extends
CoarseGrainedClusterMessage
- case class AddWebUIFilter(filterName:String, filterParams: Map[String,
String], proxyBase :String)
+ case class AddWebUIFilter(filterName:String, filterParams: Map[String,
String], proxyBase: String)
--- End diff --
minor, but since you're moving the handling of this message to
yarn-specific code, shouldn't the class defining the message also be moved out
of this more generic class?
On the other hand, while the message is only used in yarn-client mode
currently, there's nothing yarn-specific about it, so the handling code could
potentially stay where it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
