Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20399#discussion_r164539188
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -75,6 +75,17 @@ private[spark] class HadoopDelegationTokenManager(
.toMap
}
+ private def safeCreateProvider(
+ createFn: => HadoopDelegationTokenProvider):
Option[HadoopDelegationTokenProvider] = {
+ try {
+ Some(createFn)
+ } catch {
+ case t: Throwable =>
+ logDebug(s"Failed to load built in provider.", t)
--- End diff --
I actually think this really should be debug. This only covers exceptions
thrown by the constructor, which really shouldn't be doing anything (and this
code is just needed because of the class linkage issue).
Individual methods like `obtainDelegationTokens` should be the ones
reporting user-actionable issues, and even them today kinda log most things at
debug level...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
