Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20427#discussion_r164620326
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java
---
@@ -25,7 +25,7 @@
* session.
*/
@InterfaceStability.Evolving
-public interface SessionConfigSupport {
+public interface SessionConfigSupport extends DataSourceV2 {
--- End diff --
This is something we left behind. For a mix-in interface, it should extend
the interface it aimed to mix in, so that we can guarantee, for example,
classes implement `SessionConfigSupport` must also implement `DataSourceV2`.
We already did it in some mix-in interfaces, e.g. the streaming read
support, `SupportsScanUnsafeRow`, `SupportsScanColumnarBatch`, etc. In this PR
I just wanna fix the remaining ones, to make them consistent.
If you feel strongly about it, I can create a JIRA ticket for it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
