Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2866#discussion_r19175249
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/MapStatusSuite.scala ---
@@ -56,37 +78,25 @@ class MapStatusSuite extends FunSuite {
assert(status.getSizeForBlock(2000) === 150L)
}
- test(classOf[HighlyCompressedMapStatus].getName + ": estimated size is
within 10%") {
--- End diff --
I removed this test because it was broken as originally written. The test
says that it tests HighlyCompressedMapStatus's error, but it was broken because
it never actually checked that the highly-compressed status was actually
created. Since this test only used 50 map outputs rather than > 2000, it never
actually exercised HighlyCompressedMapStatus's code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
