Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20438#discussion_r164719793 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java --- @@ -135,9 +135,7 @@ public UTF8String getUTF8String(int ordinal) { @Override public CalendarInterval getInterval(int ordinal) { - int month = data.getChild(0).getInt(offset + ordinal); - long microseconds = data.getChild(1).getLong(offset + ordinal); - return new CalendarInterval(month, microseconds); + return data.getInterval(offset + ordinal); --- End diff -- We should insert `if (data.isNullAt(offset + ordinal)) return null;` to be consistent with other `ColumnarXxx`s? Or I guess we can remove these null-checks from all other `ColumnarXxx`s and leave it to `ColumnVector.getInterval()`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org