Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20408#discussion_r164774722
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage.js ---
@@ -416,8 +422,7 @@ $(document).ready(function () {
},
{data: 'hostPort'},
{data: 'isActive', render: function (data, type,
row) {
- if (row.isBlacklisted) return "Blacklisted";
- else return formatStatus (data, type);
+ return formatStatus (data, type, row);
--- End diff --
ok nevermind -- now I see the old code didn't seem to follow the convention
in the rest of this file. Not sure about the style guide for js, but I think
this might be a bit cleaner if we put each element on its own line, so the
nesting is cleaner, like it is here:
https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/executorspage.js#L459-L476
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
