Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20462#discussion_r165243779
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
    @@ -42,9 +42,9 @@ protected AbstractAppHandle(LauncherServer server) {
       }
     
       @Override
    -  public synchronized void addListener(Listener l) {
    +  public void addListener(Listener l) {
    --- End diff --
    
    why remove `synchronized` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to