Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20400 Yup, we could also string as a column but I was thinking of matching the signature with the Scala one for now, just for consistency .. On 1 Feb 2018 5:24 pm, "Liang-Chi Hsieh" <notificati...@github.com> wrote: *@viirya* commented on this pull request. ------------------------------ In python/pyspark/sql/window.py <https://github.com/apache/spark/pull/20400#discussion_r165284238>: > """ - if start <= Window._PRECEDING_THRESHOLD: - start = Window.unboundedPreceding - if end >= Window._FOLLOWING_THRESHOLD: - end = Window.unboundedFollowing + if isinstance(start, (int, long)) and isinstance(end, (int, long)): Is it possibly that we mix int and Column in the parameters? ------------------------------ In python/pyspark/sql/window.py <https://github.com/apache/spark/pull/20400#discussion_r165284328>: > any value greater than or equal to min(sys.maxsize, 9223372036854775807). """ - if start <= Window._PRECEDING_THRESHOLD: - start = Window.unboundedPreceding - if end >= Window._FOLLOWING_THRESHOLD: - end = Window.unboundedFollowing + if isinstance(start, (int, long)) and isinstance(end, (int, long)): ditto. â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/apache/spark/pull/20400#pullrequestreview-93195310>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGLXhdPpCrSrpXKsNU3qTUy17dXMGLmfks5tQXTDgaJpZM4Rtjrt> .
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org