Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20445#discussion_r165543767
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala 
---
    @@ -89,7 +96,7 @@ case class MemoryStream[A : Encoder](id: Int, sqlContext: 
SQLContext)
     
       def addData(data: TraversableOnce[A]): Offset = {
         val encoded = data.toVector.map(d => encoder.toRow(d).copy())
    -    val plan = new LocalRelation(schema.toAttributes, encoded, isStreaming 
= true)
    +    val plan = new LocalRelation(attributes, encoded, isStreaming = false)
         val ds = Dataset[A](sqlContext.sparkSession, plan)
         logDebug(s"Adding ds: $ds")
    --- End diff --
    
    Good point. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to