Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20492#discussion_r165804011
  
    --- Diff: 
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
 ---
    @@ -77,7 +77,7 @@ public UnsafeSorterSpillReader(
                  
SparkEnv.get().conf().getDouble("spark.unsafe.sorter.spill.read.ahead.fraction",
 0.5);
     
         final boolean readAheadEnabled = SparkEnv.get() != null &&
    -        
SparkEnv.get().conf().getBoolean("spark.unsafe.sorter.spill.read.ahead.enabled",
 true);
    +        
SparkEnv.get().conf().getBoolean("spark.unsafe.sorter.spill.read.ahead.enabled",
 false);
    --- End diff --
    
    Can we add a comment here to add more context? Perhaps also link a 
JIRA/TODO to re-enable this in 2.4?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to