Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20505#discussion_r165889177
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala 
---
    @@ -165,11 +165,15 @@ abstract class SQLImplicits extends 
LowPrioritySQLImplicits {
       def newProductSeqEncoder[A <: Product : TypeTag]: Encoder[Seq[A]] = 
ExpressionEncoder()
     
       /** @since 2.2.0 */
    -  implicit def newSequenceEncoder[T <: Seq[_] : TypeTag]: Encoder[T] = 
ExpressionEncoder()
    +  implicit def newSequenceEncoder[T[_], E : Encoder]
    --- End diff --
    
    Can you check if we are breaking some public contract here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to