Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20477#discussion_r166175748
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala
 ---
    @@ -36,11 +38,14 @@ import org.apache.spark.sql.types.StructType
      */
     case class DataSourceV2ScanExec(
         fullOutput: Seq[AttributeReference],
    -    @transient reader: DataSourceReader)
    +    @transient reader: DataSourceReader,
    +    @transient sourceClass: Class[_ <: DataSourceV2])
       extends LeafExecNode with DataSourceReaderHolder with ColumnarBatchScan {
     
       override def canEqual(other: Any): Boolean = 
other.isInstanceOf[DataSourceV2ScanExec]
     
    +  override def simpleString: String = s"Scan $metadataString"
    --- End diff --
    
    I've replied on that PR. I don't think overwriting `nodeName` is the right 
way to fix the UI issue, as we need to overwrite more methods. We can discuss 
more on that PR about this problem, but it should not block this PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to