Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20513#discussion_r166244254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
---
@@ -61,6 +61,9 @@ case class InMemoryTableScanExec(
}) && !WholeStageCodegenExec.isTooManyFields(conf, relation.schema)
}
+ // TODO: revisit this. Shall we always turn off whole stage codegen if
the output data are rows?
+ override def supportCodegen: Boolean = supportsBatch
--- End diff --
We confirmed that we got performance improvements in several cases.
I will revisit this with more cases after 2.3 release.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
