Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20522#discussion_r166460621
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -189,12 +189,13 @@ case class RelationConversions(
private def convert(relation: HiveTableRelation): LogicalRelation = {
val serde =
relation.tableMeta.storage.serde.getOrElse("").toLowerCase(Locale.ROOT)
if (serde.contains("parquet")) {
- val options = relation.tableMeta.storage.properties +
(ParquetOptions.MERGE_SCHEMA ->
-
conf.getConf(HiveUtils.CONVERT_METASTORE_PARQUET_WITH_SCHEMA_MERGING).toString)
+ val options = relation.tableMeta.properties ++
relation.tableMeta.storage.properties +
+ (ParquetOptions.MERGE_SCHEMA ->
+
conf.getConf(HiveUtils.CONVERT_METASTORE_PARQUET_WITH_SCHEMA_MERGING).toString)
sessionCatalog.metastoreCatalog
.convertToLogicalRelation(relation, options,
classOf[ParquetFileFormat], "parquet")
} else {
- val options = relation.tableMeta.storage.properties
+ val options = relation.tableMeta.properties ++
relation.tableMeta.storage.properties
--- End diff --
This place is only for `convertMetastore`. I think we need this inevitably
to prevent regression.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
