Github user zhzhan commented on the pull request:

    https://github.com/apache/spark/pull/2241#issuecomment-60148210
  
    @marmbrus Thanks for the comments. 
    
    Given that we have to support hive-0.12. There are two approaches I can 
think out to address the issue. 
    
    1st: we can temporally make the compatibility test  as hive12 only in pom, 
and find a good way as followup to add corresponding compatibility test for 
hive0.13 in an elegant way. This approach also unblock some other jiras and 
build the foundation for further development  of hive 0.13 feature support. 
    
    2nd: we can create a set of separate files for hive-0.13, e.g., 
compatibility suite, golden plan, golden answer, which may involve more than 
hundreds of files. In addition we need to change the current basic hive test 
code to adapt to different hive version. I think this approach may be a little 
rush, and also make the scope of this PR really big and hard to maintain.
    
    I prefer the first approach, and opening followup jiras to address 
leftovers in a more granular way.
    
    Please let know how you do think about it. If you have other options, 
please also  let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to