Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20531#discussion_r166646442
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -3715,10 +3715,10 @@ def foo(x):
             self.assertEqual(foo.returnType, schema)
             self.assertEqual(foo.evalType, 
PythonEvalType.SQL_GROUPED_MAP_PANDAS_UDF)
     
    -        @pandas_udf(returnType='v double', 
functionType=PandasUDFType.SCALAR)
    +        @pandas_udf(returnType='double', functionType=PandasUDFType.SCALAR)
             def foo(x):
                 return x
    -        self.assertEqual(foo.returnType, schema)
    +        self.assertEqual(foo.returnType, schema[0].dataType)
    --- End diff --
    
    Should we just:
    ```
    self.assertEqual(foo.returnType, DoubleType())
    ```
    ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to