Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20529#discussion_r166768784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -92,12 +92,14 @@ case class WriteToDataSourceV2Exec(writer:
DataSourceWriter, query: SparkPlan) e
logInfo(s"Data source writer $writer committed.")
}
} catch {
- case _: InterruptedException if writer.isInstanceOf[StreamWriter] =>
- // Interruption is how continuous queries are ended, so accept and
ignore the exception.
+ case _: SparkException if writer.isInstanceOf[StreamWriter] =>
--- End diff --
This seems like it swallows too much now. Any error is interpreted as
something to ignore. That doesn't sound right nor is it consistent with the
comment. I don't know the code well though.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
