Github user LantaoJin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20532#discussion_r166855350
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -53,10 +53,21 @@ package object config {
           .booleanConf
           .createWithDefault(false)
     
    -  private[spark] val EVENT_LOG_BLOCK_UPDATES =
    -    ConfigBuilder("spark.eventLog.logBlockUpdates.enabled")
    -      .booleanConf
    -      .createWithDefault(false)
    +  private[spark] val EVENT_LOG_BLOCK_UPDATES_FRACTION =
    +    ConfigBuilder("spark.eventLog.logBlockUpdates.fraction")
    +      .doc("Expected number of times each blockUpdated event is chosen to 
log, " +
    +        "fraction must be [0, 1]. 0 by default, means disabled")
    +      .doubleConf
    +      .checkValue(_ >= 0, "The fraction must not be negative")
    --- End diff --
    
    It is not only for debugging, but also for deploying to all applications. 
So we need a safe way to do that. That's max limitation seems much acceptable 
than just enabled or disabled.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to