Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20362#discussion_r167005865
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -599,8 +598,11 @@ class ALSSuite
               (ex, act) =>
                 ex.userFactors.first().getSeq[Float](1) === 
act.userFactors.first.getSeq[Float](1)
             } { (ex, act, _) =>
    -          ex.transform(_: 
DataFrame).select("prediction").first.getDouble(0) ~==
    -            act.transform(_: 
DataFrame).select("prediction").first.getDouble(0) absTol 1e-6
    +          testTransformerByGlobalCheckFunc[Float](_: DataFrame, act, 
"prediction") {
    +            case actRows: Seq[Row] =>
    +              ex.transform(_: 
DataFrame).select("prediction").first.getDouble(0) ~==
    +                actRows(0).getDouble(0) absTol 1e-6
    +          }
    --- End diff --
    
    Woah, didn't check the original functionality in such a depth. This is 
really dead code in runtime environment. Fixed 👍 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to