Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20555#discussion_r167391309
  
    --- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java 
---
    @@ -232,7 +229,9 @@ private void waitForAsyncReadComplete() throws 
IOException {
         stateChangeLock.lock();
         try {
           while (readInProgress) {
    +        isWaiting.set(true);
             asyncReadComplete.await();
    +        isWaiting.set(false);
    --- End diff --
    
    What happens if `await()` throws an exception? Is it ok not to update 
`isWaiting`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to