Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r167419965
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
---
@@ -51,6 +51,22 @@ public void testKnownLongInputs() {
Assert.assertEquals(-2106506049, hasher.hashLong(Long.MAX_VALUE));
}
+ @Test
+ public void testKnownBytesInputs() {
+ byte[] test = "test".getBytes(StandardCharsets.UTF_8);
+ Assert.assertEquals(-1167338989,
--- End diff --
Is it better to compare the result of murmur3 hash value by scala library?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
