Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20571#discussion_r167437130
--- Diff: dev/make-distribution.sh ---
@@ -72,8 +76,15 @@ while (( "$#" )); do
--help)
exit_with_usage
;;
+ --*)
--- End diff --
I think this is fine. It will print usage for every unrecognized arg, but,
that's probably OK, as it's rare to have more than one.
I guess the other option is to fail outright to make sure the user knows
the command wasn't parsed as given. How about that? I don't feel strongly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
