Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20406#discussion_r167456217
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeSuite.scala
---
@@ -100,6 +100,25 @@ class HiveSerDeSuite extends HiveComparisonTest with
PlanTest with BeforeAndAfte
assert(output ==
Some("org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat"))
assert(serde ==
Some("org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe"))
}
+
+ withSQLConf("hive.default.fileformat" -> "orc") {
--- End diff --
Actually, this PR does not need to improve the test coverage. What we
really need to do is to confirm whether Hive's default serde are the ones added
by this PR. Anybody can run it and post the results here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
