Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20546#discussion_r167612371
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
 ---
    @@ -610,7 +610,7 @@ class StandaloneDynamicAllocationSuite
        * we submit a request to kill them. This must be called before each 
kill request.
        */
       private def syncExecutors(sc: SparkContext): Unit = {
    -    val driverExecutors = sc.getExecutorStorageStatus
    --- End diff --
    
    As only registered executors can be killed this part synchronised the 
executors known by the master and the driver (the missing executors from the 
driver was registered with some mock data). The reason behind was some 
performance. 
    
    I have run tried to change the code to wait for the executors and it get 
very slow (one test took even 50 seconds long).   


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to