Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2615#discussion_r19260267
  
    --- Diff: bin/compute-classpath.sh ---
    @@ -20,7 +20,7 @@
     # This script computes Spark's classpath and prints it to stdout; it's 
used by both the "run"
     # script and the ExecutorRunner in standalone cluster mode.
     
    -SCALA_VERSION=2.10
    +SCALA_VERSION=${SCALA_VERSION:-"2.10"}
    --- End diff --
    
    Actually I think we need to add explicitly a version to the classpath. Can 
we just detect the version by doing `ls core/target`? If we see compiled files 
for both scala 2.10 and 2.11 we can throw an error and ask the user to remove 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to