Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20545#discussion_r167764844
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala ---
    @@ -134,6 +134,15 @@ class DataTypeSuite extends SparkFunSuite {
         assert(mapped === expected)
       }
     
    +  test("fieldNames and names returns field names") {
    +    val struct = StructType(
    +      StructField("a", LongType) :: StructField("b", FloatType) :: Nil)
    +
    +    assert(struct.fieldNames === Seq("a", "b"))
    +    assert(struct.names === Seq("a", "b"))
    +    assert(struct.fieldNames === struct.names)
    --- End diff --
    
    this line is redundant. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to