Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20511#discussion_r167955019
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ---
    @@ -160,6 +160,16 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
           }
         }
       }
    +
    +  // This is a test case for ORC-285
    +  test("SPARK-23340 Empty float/double array columns raise EOFException") {
    +    Seq(Seq(Array.empty[Float]).toDF(), 
Seq(Array.empty[Double]).toDF()).foreach { df =>
    --- End diff --
    
    We can test for both case, but vectorized reader path is not enabled for a 
complex schema.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to