Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20419#discussion_r167958486
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1226,14 +1226,21 @@ class CodegenContext {
     
       /**
        * Register a comment and return the corresponding place holder
    +   *
    +   * @param placeholderId a string for a place holder
    +   * @param force whether to force registering the comments
        */
    -  def registerComment(text: => String): String = {
    +  def registerComment(
    +      text: => String,
    +      placeholderId: String = "",
    +      force: Boolean = false): String = {
         // By default, disable comments in generated code because computing 
the comments themselves can
         // be extremely expensive in certain cases, such as deeply-nested 
expressions which operate over
         // inputs with wide schemas. For more details on the performance 
issues that motivated this
         // flat, see SPARK-15680.
    -    if (SparkEnv.get != null && 
SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments", false)) {
    -      val name = freshName("c")
    +    if (force ||
    +      SparkEnv.get != null && 
SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments", false)) {
    --- End diff --
    
    IIUC, the answer seems to be No. See [this 
discussion](https://github.com/apache/spark/pull/19449#discussion_r143291724).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to