Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20594
  
    Because this is a quick fix, my idea is to have a surface patch that 
doesn't change existing API. The approach of adding parameter to 
`DefaultParamsWriter.saveMetadata` also sounds good to me, but the parameter 
seems useless if we get rid of this quick fix in the future.
    
    Instead of adding parameter, I think we can pass the `paramMap` parameter 
when calling `saveMetadata`.
    
    For #20410 and #18982, I have a question, are they regression? Seems to me 
they are not new issues to 2.3.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to