Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r168511774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -770,7 +837,14 @@ case class Unhex(child: Expression) extends
UnaryExpression with ImplicitCastInp
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(expr1, expr2) - Returns the angle in radians between the
positive x-axis of a plane and the point given by the coordinates (`expr1`,
`expr2`).",
+ usage = "_FUNC_(exprY, exprX) - Returns the angle in radians between the
positive x-axis of a plane and the point given by the coordinates (`exprX`,
`exprY`), " +
+ "as if computed by `java.lang.Math._FUNC_`.",
+ arguments =
+ """
+ Arguments:
+ * exprY - the ordinate coordinate
+ * exprX - the abscissa coordinate
--- End diff --
Here and below -- it's not clear how ordinate and abscissa relate to the
function's description. Above it's described more simply as the coordinates of
a point in the plane, and I think that's more recognizable than these terms.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
