GitHub user andrusha opened a pull request:

    https://github.com/apache/spark/pull/20628

    Preserve extraJavaOptions ordering

    For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is 
necessary.
    
    ## What changes were proposed in this pull request?
    
    Keep original extraJavaOptions ordering, when passing them through 
environment variables inside the Docker container.
    
    ## How was this patch tested?
    
    Ran base branch a couple of times and checked startup command in logs. 
Ordering differed every time. Added sorting, ordering was consistent to what 
user had in `extraJavaOptions`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andrusha/spark patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20628
    
----
commit 6759e9e9f9075427b87fe5071e803c60d7521629
Author: Andrew Korzhuev <korzhuev@...>
Date:   2018-02-16T14:24:48Z

    Preserve extraJavaOptions ordering
    
    For some JVM options, like `-XX:+UnlockExperimentalVMOptions` ordering is 
necessary.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to