Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r168922556
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -270,8 +269,14 @@ private[tree] class LearningNode(
* Convert this [[LearningNode]] to a regular [[Node]], and recurse on
any children.
*/
def toNode: Node = {
- if (leftChild.nonEmpty) {
- assert(rightChild.nonEmpty && split.nonEmpty && stats != null,
+ /**
--- End diff --
Nit: this is scaladoc comment syntax. Use `//` for inline comments
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
