Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20572#discussion_r169489462
--- Diff:
external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/CachedKafkaConsumer.scala
---
@@ -53,7 +51,7 @@ class CachedKafkaConsumer[K, V] private(
// TODO if the buffer was kept around as a random-access structure,
// could possibly optimize re-calculating of an RDD in the same batch
- protected var buffer = ju.Collections.emptyList[ConsumerRecord[K,
V]]().iterator
+ protected var buffer =
ju.Collections.emptyListIterator[ConsumerRecord[K, V]]()
--- End diff --
Was going to comment on the fact that it's `protected`, and what if a
subclass depend on this, but, as the whole class is package-private I guess
that's not an issue?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
