Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2901#discussion_r19313312
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/json/JsonRDD.scala 
---
    @@ -372,13 +372,20 @@ private[sql] object JsonRDD extends Logging {
         }
       }
     
    +  private def toDate(value: Any): Date = {
    +    value match {
    +      // only support string as date
    +      case value: java.lang.String => Date.valueOf(value)
    --- End diff --
    
    Could you add more formats support for Date? At least ISO8601, see some 
discussion here: 
http://stackoverflow.com/questions/10286204/the-right-json-date-format
    
    We would like have jsonRDD() as robust as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to