Github user skonto commented on the issue:

    https://github.com/apache/spark/pull/20640
  
    @susanxhuynh I agree in case it is not enabled we can log failures as 
usual, but not for blacklisting as it is disabled it wouldnt make sense. User 
should have this option not to care. 
    
    > In the case where an executor fails before entering Spark code (for 
example, Mesos agent failed to create the sandbox), would it be detected?
    
    Good question forgot to mention this. In this scenario a task status update 
will be given
    eg. 
[REASON_CONTAINER_LAUNCH_FAILED](https://github.com/apache/mesos/blob/5e5a8102c3281db25a37157dac123b0ca546e030/docs/task-state-reasons.md)
    
    This is done implicitly 
[here](https://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala#L658)
  in status update which then calls [removeExecutor 
](https://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala#L728)
 which then sends a message to drivers point to remove the executor and then 
this 
[line](https://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala#L330)
 is called which then will calls another helper 
[method](https://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L536),
 which calls this [one](ht
 
tps://github.com/apache/spark/blob/f41c0a93fd3913ad93e55ddbfd875229872ecc97/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L595)
 and in there blacklist info is updated.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to