Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20604#discussion_r170102582
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -334,6 +336,11 @@ private[spark] class ExecutorAllocationManager(
// If the new target has not changed, avoid sending a message to the
cluster manager
if (numExecutorsTarget < oldNumExecutorsTarget) {
+ // We lower the target number of executors but don't actively kill
any yet. Killing is
+ // controlled separately by an idle timeout. Its still helpful to
reduce the target number
+ // in case an executor just happens to get lost (eg., bad
hardware, or the cluster manager
+ // preempts it) -- in that case, there is no point in trying to
immediately get a new
+ // executor, since we couldn't even use it yet.
--- End diff --
s/couldn't/wouldn't
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
