Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20553#discussion_r170138218
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
 ---
    @@ -144,7 +149,7 @@ private[spark] class ExecutorPodFactory(
         val executorEnv = (Seq(
           (ENV_DRIVER_URL, driverUrl),
           // Executor backend expects integral value for executor cores, so 
round it up to an int.
    -      (ENV_EXECUTOR_CORES, math.ceil(executorCores).toInt.toString),
    +      (ENV_EXECUTOR_CORES, executorCores.toString),
    --- End diff --
    
    The comment above is now outdated and can be removed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to