Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/20624#discussion_r170465726 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -305,15 +260,15 @@ object ColumnStat extends Logging { percentiles: Option[ArrayData]): ColumnStat = { // The first 6 fields are basic column stats, the 7th is ndvs for histogram bins. val cs = ColumnStat( - distinctCount = BigInt(row.getLong(0)), + distinctCount = Option(BigInt(row.getLong(0))), --- End diff -- I'd keep it an Option, just to be prepared for more flexibility and more optionality, unless you have a strong opinion. (note: this code has moved to AnalyzeColumnCommand)
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org