Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r170505359
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -50,12 +52,11 @@
// These are only updated by readExternal() or read()
@Nonnull
- private Object base;
- private long offset;
+ private MemoryBlock base;
private int numBytes;
--- End diff --
It's weird to see a `MemoryBlock` and `numBytes` pair, as `MemoryBlock`
already has a `length` property. How about we allow projection on
`MemoryBlock`? i.e. allow to increase the base offset and decrease the length.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
